1111352 - Incomplete keyboard layout can silently break keyboard app build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[:gerard-majax]

Reproduced after building and updating my Nexus S, which is running current master.

On boot, logcat shows:
> 12-14 17:23:01.660    77    77 E GeckoConsole: Content JS ERROR: InputAppList: No input apps installed? 
> 12-14 17:23:01.660    77    77 E GeckoConsole:     at InputAppList.prototype._setInputApps (app://system.gaiamobile.org/shared/js/input_mgmt/input_app_list.js:273:4)

Comment 1

[:gerard-majax]

Maybe a build issue: comparing the list of applications in my profile with the latest update package I produced and this one, I see the keyboard application is missing.

Comment 2

[:gerard-majax]

Attachment: Profile built

Comment 3

[:gerard-majax]

Attachment: profile webapps.json

Please note we have a keyboard app defined in webapps.json, but there is no folder in the profile

Comment 4

[:gerard-majax]

Attachment: Keyboard build error

Any idea why this build error did not resulted in a general build failure ?

|./build.sh gaia| succedded with this in the middle :(

Comment 5

[:gerard-majax]

The error mentions 'te' keyboard, introduced in bug 1046900.

Comment 6

[:gerard-majax]

Changing the title to properly describe the real issue. This is not the first time that it happens, can we take mitigations measures ?

Like, adding test case to make sure we do build all keyboard properly, etc. ?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Our Gb tests currently build with default config, you must be using some other build config.

That said, I agree with you we should create keyboard build script test for these configs.

Comment 8

[:gerard-majax]

Yes, I have this in my .userconfig:
> export GAIA_KEYBOARD_LAYOUTS="$((find gaia/apps/keyboard/js/layouts/*.js | sed -e 's|gaia/apps/keyboard/js/layouts/||g' -e 's/\.js$//g') | tr -s '\r\n' ',' | sed -e 's/,$//g')"

Comment 9

[:gerard-majax]

Just in case it happens to anyone else, I had to remove objdir-gecko/, make a clean in gaia, and then rebuild a FOTA package to sideload. This made the keyboard application back. Then I had to go to Settings and reconfigure keyboards to get it back working.

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Agree with Tim, adding keyboard integration test in build/test/integration for ensuring keyboard-related parameters (ex: GAIA_KEYBOARD_LAYOUTS) to work properly.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The other issue is that when the app build step failed, the Gaia build will succeed with the package missing. That's a silent error we can't afford.

Ricky, could you setup the keyboard app build test based on script in comment 8, and also fix the issue above? Thanks. We probably need it before bug 1029951 can land.

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Sure! Maybe I'm not really understand how to verify keyboard-layout. I'll needinfo keyboard partners if I have further question.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update: Talked to Ricky offline. We will land a basic test asserting the default keyboard config here, and I will follow up with a test supporting build w/ all layouts in bug 1112460 (since a GAIA_KEYBOARD_LAYOUTS=* shortcut will be landed there). Ricky will clone another bug for fixing comment 11 (ensure the build failed when app build step fails).

Comment 14

[Ricky Chien [:rickychien] (inactive)]

As mentioned on comment 11, Bug 1112490 has been filed to address the silent error. And I'm going to land a test for default keyboard as soon as possible.

Comment 15

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR for keyboard test

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8537738 [details] [review]
Gaia PR for keyboard test

Please move it to apps/keyboard/test/build/integration and set r to me again, thanks!

Comment 17

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8537738 [details] [review]
Gaia PR for keyboard test

PR updated! Please check it again thanks!

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8537738 [details] [review]
Gaia PR for keyboard test

LGTM, r=gduan

Comment 19

[Ricky Chien [:rickychien] (inactive)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/23fe7747887a825c9f6de878a37744255efee058